Use atomic.Int32 in namespace registry #8945
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnr
reviewed
Jan 6, 2026
Contributor
dnr
left a comment
dnr
left a comment
There was a problem hiding this comment.
I think we should remove this atomic status pattern entirely. I've been removing it from modules that I touch. All lifecycle management for objects with process-lifetime should be done through fx, which serializes all Start/Stop calls. (Objects with other lifetimes may need other approaches.)
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Replaced the plain int32 status field in the namespace registry with atomic.Int32. Updated Start() and Stop() to use the type's methods instead of package-level atomic functions.
Why?
Using atomic.Int32 is more type-safe and idiomatic in modern Go.
How did you test it?
Potential risks
None. This is a mechanical refactor with identical runtime behavior.